Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2997)

Unified Diff: chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc

Issue 10417032: Disable sync promo when RestoreOnStartupURLs policy is used (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
diff --git a/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc b/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
index f269484ae7bcb2d5f77ce8aa6cf4086100c8af6b..a8cb1fdc438e04b09c44a79daaaf64951d383790 100644
--- a/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
+++ b/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
@@ -172,8 +172,8 @@ bool SyncPromoUI::ShouldShowSyncPromoAtStartup(Profile* profile,
if (show_count >= kSyncPromoShowAtStartupMaximum)
return false;
- // This pref can be set in the master preferences file to allow or disallow
- // showing the sync promo at startup.
+ // Check whether the sync promo has been disabled by a pref. This will always
+ // automatically be the case when the RestoreOnStartupURLs policy is set.
Mattias Nissler (ping if slow) 2012/05/22 14:58:41 Please retain the master_preferences reference in
bartfab (slow) 2012/05/22 15:30:54 Done.
if (prefs->HasPrefPath(prefs::kSyncPromoShowOnFirstRunAllowed))
return prefs->GetBoolean(prefs::kSyncPromoShowOnFirstRunAllowed);

Powered by Google App Engine
This is Rietveld 408576698