Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 10417031: Fix TestingAutomationProvider::SimulateAsanMemoryBug. (Closed)

Created:
8 years, 7 months ago by glotov
Modified:
8 years, 7 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, robertshield, kkania
Visibility:
Public.

Description

Fix TestingAutomationProvider::SimulateAsanMemoryBug. 1) Return before cause a crash. 2) Add `volatile` so that the compiler does not optimize us out. FYI, The test initially added here: https://gerrit.chromium.org/gerrit/#change,23212 BUG=chromium:126774 TEST=./run_remote_tests.sh client/site_tests/logging_AsanCrash Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138463

Patch Set 1 #

Total comments: 2

Patch Set 2 : more comments #

Total comments: 1

Patch Set 3 : "API -> method" #

Patch Set 4 : bot fix #

Patch Set 5 : sync #

Patch Set 6 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 4 5 1 chunk +10 lines, -4 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
glotov
Hi! Just a two lines change. Please have a look.
8 years, 7 months ago (2012-05-22 14:34:09 UTC) #1
Nirnimesh
http://codereview.chromium.org/10417031/diff/1/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): http://codereview.chromium.org/10417031/diff/1/chrome/browser/automation/testing_automation_provider.cc#newcode5894 chrome/browser/automation/testing_automation_provider.cc:5894: volatile int testarray[41]; please make a note here why ...
8 years, 7 months ago (2012-05-22 16:29:43 UTC) #2
glotov
All done, please have another look.
8 years, 7 months ago (2012-05-22 16:38:53 UTC) #3
Nirnimesh
8 years, 7 months ago (2012-05-22 16:43:24 UTC) #4
LGTM

http://codereview.chromium.org/10417031/diff/5001/chrome/test/pyautolib/pyaut...
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/10417031/diff/5001/chrome/test/pyautolib/pyaut...
chrome/test/pyautolib/pyauto.py:4034: This API returns immediately before it
actually causes a crash.
API -> method

Powered by Google App Engine
This is Rietveld 408576698