Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/objects-inl.h

Issue 10417030: Decoupling MarkDescriptorArray as much as possible from the ContentArray. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: removing were to be Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1921 matching lines...) Expand 10 before | Expand all | Expand 10 after
1932 return number; 1932 return number;
1933 } 1933 }
1934 1934
1935 1935
1936 String* DescriptorArray::GetKey(int descriptor_number) { 1936 String* DescriptorArray::GetKey(int descriptor_number) {
1937 ASSERT(descriptor_number < number_of_descriptors()); 1937 ASSERT(descriptor_number < number_of_descriptors());
1938 return String::cast(get(ToKeyIndex(descriptor_number))); 1938 return String::cast(get(ToKeyIndex(descriptor_number)));
1939 } 1939 }
1940 1940
1941 1941
1942 Object** DescriptorArray::GetValueSlot(int descriptor_number) {
1943 ASSERT(descriptor_number < number_of_descriptors());
1944 return GetContentArray()->data_start() + ToValueIndex(descriptor_number);
1945 }
1946
1947
1942 Object* DescriptorArray::GetValue(int descriptor_number) { 1948 Object* DescriptorArray::GetValue(int descriptor_number) {
1943 ASSERT(descriptor_number < number_of_descriptors()); 1949 ASSERT(descriptor_number < number_of_descriptors());
1944 return GetContentArray()->get(ToValueIndex(descriptor_number)); 1950 return GetContentArray()->get(ToValueIndex(descriptor_number));
1945 } 1951 }
1946 1952
1947 1953
1948 PropertyDetails DescriptorArray::GetDetails(int descriptor_number) { 1954 PropertyDetails DescriptorArray::GetDetails(int descriptor_number) {
1949 ASSERT(descriptor_number < number_of_descriptors()); 1955 ASSERT(descriptor_number < number_of_descriptors());
1950 Object* details = GetContentArray()->get(ToDetailsIndex(descriptor_number)); 1956 Object* details = GetContentArray()->get(ToDetailsIndex(descriptor_number));
1951 return PropertyDetails(Smi::cast(details)); 1957 return PropertyDetails(Smi::cast(details));
(...skipping 3108 matching lines...) Expand 10 before | Expand all | Expand 10 after
5060 #undef WRITE_UINT32_FIELD 5066 #undef WRITE_UINT32_FIELD
5061 #undef READ_SHORT_FIELD 5067 #undef READ_SHORT_FIELD
5062 #undef WRITE_SHORT_FIELD 5068 #undef WRITE_SHORT_FIELD
5063 #undef READ_BYTE_FIELD 5069 #undef READ_BYTE_FIELD
5064 #undef WRITE_BYTE_FIELD 5070 #undef WRITE_BYTE_FIELD
5065 5071
5066 5072
5067 } } // namespace v8::internal 5073 } } // namespace v8::internal
5068 5074
5069 #endif // V8_OBJECTS_INL_H_ 5075 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698