Issue 10417027: Restrict throbber messages to SingleSuggestionView objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10417027: Restrict throbber messages to SingleSuggestionView objects. (Closed)

Created:
8 years, 7 months ago by groby-ooo-7-16

Modified:
8 years, 7 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Restrict throbber messages to SingleSuggestionView objects. R=rsesek@chromium.org BUG=129176, 129082 TEST=Try to install the first item from suggestion list. Without this fix, that will crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138305

Patch Set 2 : Remove extraneous logging. #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	chrome/browser/ui/cocoa/web_intent_sheet_controller.mm	View	1	1 chunk	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

lgtm https://chromiumcodereview.appspot.com/10417027/diff/1/chrome/browser/ui/cocoa/web_intent_sheet_controller.mm File chrome/browser/ui/cocoa/web_intent_sheet_controller.mm (right): https://chromiumcodereview.appspot.com/10417027/diff/1/chrome/browser/ui/cocoa/web_intent_sheet_controller.mm#newcode412 chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:412: NSLog(@"Throbberizing"); nix

8 years, 7 months ago (2012-05-22 16:52:53 UTC) #3

groby-ooo-7-16

8 years, 7 months ago (2012-05-22 16:58:48 UTC) #4

https://chromiumcodereview.appspot.com/10417027/diff/1/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/web_intent_sheet_controller.mm (right):

https://chromiumcodereview.appspot.com/10417027/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:412:
NSLog(@"Throbberizing");
Ooops - sorry for missing that, and thanks for the catch!
On 2012/05/22 16:52:53, rsesek wrote:
> nix

Expand Messages | Collapse Messages

Issue 10417027: Restrict throbber messages to SingleSuggestionView objects. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove extraneous logging. #

Messages