PPAPI/NaCl: Fix IPC proxy build; pthread_t changed

PPAPI/NaCl: Fix IPC proxy build; pthread_t changed

We broke when NaCl DEPS were rolled, giving us this change:
r8650: (mseaborn) libpthread: Make pthread_t a pointer instead of a small integer ID

BUG=116317
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138261

[bbudge, 2012-05-22 01:45:33]

lgtm

I ran into the platform_thread_posix issue too!

[bbudge, 2012-05-22 01:58:14]

http://codereview.chromium.org/10417026/diff/1/base/threading/platform_thread...
File base/threading/platform_thread_posix.cc (right):

http://codereview.chromium.org/10417026/diff/1/base/threading/platform_thread...
base/threading/platform_thread_posix.cc:166: return
reinterpret_cast<int64>(pthread_self());
Maybe it would be better to cast to int32 since ptrs are 32 bits in NaCl.

[commit-bot: I haz the power, 2012-05-22 01:59:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/10417026/1

[commit-bot: I haz the power, 2012-05-22 01:59:40]

Failed to apply patch for build/all.gyp:
While running patch -p1 --forward --force;
patching file build/all.gyp
Hunk #1 FAILED at 23.
1 out of 1 hunk FAILED -- saving rejects to file build/all.gyp.rej

[commit-bot: I haz the power, 2012-05-22 02:12:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/10417026/8001

[commit-bot: I haz the power, 2012-05-22 02:12:20]

Presubmit check for 10417026-8001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    base/threading

[dmichael (off chromium), 2012-05-22 03:03:55]

+brettw for OWNERS approval

[brettw, 2012-05-22 03:59:28]

lgtm

[commit-bot: I haz the power, 2012-05-22 04:44:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/10417026/8001

[commit-bot: I haz the power, 2012-05-22 10:27:37]

Try job failure for 10417026-8001 (retry) (retry) on win_rel for steps
"base_unittests, sync_unit_tests" (clobber build).
It's a second try, previously, steps "base_unittests, sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Mark Seaborn, 2012-05-22 16:39:39]

https://chromiumcodereview.appspot.com/10417026/diff/8001/base/threading/plat...
File base/threading/platform_thread_posix.cc (right):

https://chromiumcodereview.appspot.com/10417026/diff/8001/base/threading/plat...
base/threading/platform_thread_posix.cc:166: // Pointers are 32-bits in NaCl.
You might also comment that we're assuming nacl-newlib's pthread implementation.
 NaCl itself does not specify that pthread_t is a pointer.

https://chromiumcodereview.appspot.com/10417026/diff/8001/base/threading/plat...
base/threading/platform_thread_posix.cc:167: return
reinterpret_cast<int32>(pthread_self());
FYI, this would break again if nacl-newlib's libpthread changed the type back to
int, because an int->int reinterpret_cast is rejected by some compilers.  A
C-style cast would avoid that problem.