Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/testing/webdriver_test_setup.py

Issue 10417025: Deal with different chromedrivers running on for Chrome and Dartium. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/perf_testing/run_perf_tests.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/webdriver_test_setup.py
===================================================================
--- tools/testing/webdriver_test_setup.py (revision 7828)
+++ tools/testing/webdriver_test_setup.py (working copy)
@@ -39,10 +39,6 @@
parser = optparse.OptionParser()
parser.add_option('--firefox', '-f', dest='firefox', help='Install Firefox',
action='store_true', default=False)
- parser.add_option('--path', '-p', dest='path', help='Specify location ' + \
- 'on your PATH for where we should install chromedriver (default is in' + \
- 'depot_tools).', metavar='CHROMEDRIVER_LOC', type='str', action='store',
- default=None)
parser.add_option('--buildbot', '-b', dest='buildbot', action='store_true',
help='Perform a buildbot selenium setup (buildbots have a different' + \
'location for their python executable).', default=False)
@@ -245,10 +241,7 @@
def main():
args = parse_args()
SeleniumBindingsInstaller(args.buildbot).run()
- chromedriver_loc = find_depot_tools_location(args.buildbot)
- if args.path:
- chromedriver_loc = args.path
- GoogleCodeInstaller('chromedriver', chromedriver_loc,
+ GoogleCodeInstaller('chromedriver', ind_depot_tools_location(args.buildbot),
lambda x: 'chromedriver_%(os)s_%(version)s.zip' % x).run()
if 'win32' not in sys.platform and 'cygwin' not in sys.platform:
GoogleCodeInstaller('selenium', os.path.dirname(os.path.abspath(__file__)),
« no previous file with comments | « tools/testing/perf_testing/run_perf_tests.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698