Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 10417019: Have Zygote fork a init-like process if required (Closed)

Created:
8 years, 7 months ago by jln (very slow on Chromium)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Have Zygote fork a init-like process if required When we use the setuid sandbox, Zygote may get launched in a new PID namespace, with pid == 1. In that case we need to act as a init process and reap zombies. BUG=125821, 109944 TEST= NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138409

Patch Set 1 #

Patch Set 2 : update the diffbase #

Patch Set 3 : update the diffbase (properly this time) #

Total comments: 12

Patch Set 4 : Address Markus' remarks #

Patch Set 5 : Switch to SOCK_STREAM instead of SOCK_DGRAM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -0 lines) Patch
M content/zygote/zygote_main_linux.cc View 1 2 3 4 3 chunks +83 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jln (very slow on Chromium)
Hello Markus, this CL lets Zygote handle having PID == 1 properly and reap the ...
8 years, 7 months ago (2012-05-21 23:25:45 UTC) #1
Markus (顧孟勤)
lgtm A bunch of minor nitpicks. But none of them really matter much. https://chromiumcodereview.appspot.com/10417019/diff/6001/content/zygote/zygote_main_linux.cc File ...
8 years, 7 months ago (2012-05-21 23:56:59 UTC) #2
jln (very slow on Chromium)
https://chromiumcodereview.appspot.com/10417019/diff/6001/content/zygote/zygote_main_linux.cc File content/zygote/zygote_main_linux.cc (right): https://chromiumcodereview.appspot.com/10417019/diff/6001/content/zygote/zygote_main_linux.cc#newcode457 content/zygote/zygote_main_linux.cc:457: if (socketpair(AF_UNIX, SOCK_DGRAM, 0, sync_fds)) { On 2012/05/21 23:57:00, ...
8 years, 7 months ago (2012-05-22 00:36:41 UTC) #3
jln (very slow on Chromium)
Brett, would you mind approving this as OWNER ? Thanks, Julien
8 years, 7 months ago (2012-05-22 00:38:40 UTC) #4
brettw
I'm rubber stamp LGTM ing this based on Markus' review since I don't understand it ...
8 years, 7 months ago (2012-05-22 21:17:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/10417019/11002
8 years, 7 months ago (2012-05-22 21:45:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/10417019/11002
8 years, 7 months ago (2012-05-23 00:53:59 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 00:54:16 UTC) #8
Change committed as 138409

Powered by Google App Engine
This is Rietveld 408576698