Issue 10416044: Merge 138264 - Re-enable embedded identities in URLs for HTTP authentication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10416044: Merge 138264 - Re-enable embedded identities in URLs for HTTP authentication. (Closed)

Created:
8 years, 7 months ago by asanka

Modified:
8 years, 7 months ago

Reviewers:
cbentzel, laforge

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1084/src/

Visibility:
Public.

More Reviews

Description

Merge 138264 - Re-enable embedded identities in URLs for HTTP authentication. This effectively reverts r121506. BUG=123150 TEST=net_unittests. Username/passwords specified in URLs work. XmlHttpReques Review URL: https://chromiumcodereview.appspot.com/10412025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138338

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+477 lines, -13 lines)			Patch
M	net/http/http_auth_controller.cc	View	1 chunk	+11 lines, -7 lines	0 comments	Download
M	net/http/http_network_transaction_spdy21_unittest.cc	View	2 chunks	+145 lines, -2 lines	0 comments	Download
M	net/http/http_network_transaction_spdy2_unittest.cc	View	2 chunks	+145 lines, -2 lines	0 comments	Download
M	net/http/http_network_transaction_spdy3_unittest.cc	View	2 chunks	+145 lines, -2 lines	0 comments	Download
M	net/url_request/url_request_unittest.cc	View	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

asanka

This CL is against branch 1084. The only notable change is the addition of changes ...

8 years, 7 months ago (2012-05-22 19:17:21 UTC) #1

cbentzel

LGTM laforge: Do you want this without the unit test changes?

8 years, 7 months ago (2012-05-22 19:39:02 UTC) #2

laforge

8 years, 7 months ago (2012-05-22 19:44:31 UTC) #3

Merge it.

Kind Regards,

Anthony Laforge
Technical Program Manager
Mountain View, CA


On Tue, May 22, 2012 at 12:39 PM, <cbentzel@chromium.org> wrote:

> LGTM
>
> laforge: Do you want this without the unit test changes?
>
>
http://codereview.chromium.**org/10416044/<http://codereview.chromium.org/104...
>

Expand Messages | Collapse Messages