Issue 10416043: Add a GYP_DEFINE to force generating /Z7 flags for Visual C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10416043: Add a GYP_DEFINE to force generating /Z7 flags for Visual C++. (Closed)

Created:
8 years, 7 months ago by arthurhsu

Modified:
8 years, 7 months ago

Reviewers:
scottmg

CC:
chromium-reviews, ukai, hamaji

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add a GYP_DEFINE to force generating /Z7 flags for Visual C++. This is required for parallel compilation tools that are unable to support /Zi. BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138549

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update per code review #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	build/common.gypi	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm with rename http://codereview.chromium.org/10416043/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/10416043/diff/1/build/common.gypi#newcode637 build/common.gypi:637: 'z7%' : 0, please change to ...

8 years, 7 months ago (2012-05-22 20:33:14 UTC) #2

arthurhsu

http://codereview.chromium.org/10416043/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/10416043/diff/1/build/common.gypi#newcode637 build/common.gypi:637: 'z7%' : 0, On 2012/05/22 20:33:15, scottmg wrote: > ...

8 years, 7 months ago (2012-05-22 20:37:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arthurhsu@chromium.org/10416043/4002

8 years, 7 months ago (2012-05-23 16:42:53 UTC) #4

Change committed as 138549

Expand Messages | Collapse Messages