Eliminate dominator and retained_size fields. They are calculating on front-end side.

Eliminate dominator and retained_size fields. They are calculating on front-end side. See meta-bug https://bugs.webkit.org/show_bug.cgi?id=87089

BUG=none
TEST=none

Committed: https://code.google.com/p/v8/source/detail?r=11626

[alexeif, 2012-05-22 16:47:03]

https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator....
src/profile-generator.cc:1003: self_size(),  id(), indent, ' ', prefix,
edge_name);
nit: extra space

https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator....
src/profile-generator.cc:3344: 6 * MaxDecimalDigitsIn<sizeof(int)>::kSigned  //
NOLINT
6 -> 4

https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator....
src/profile-generator.cc:3346: + 7 + 1 + 1;
7 -> 5

https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator.h
File src/profile-generator.h (right):

https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator....
src/profile-generator.h:487: int from_index_ : 29;
Looks like we can kill from_index_ now. Isn't it?

https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator....
src/profile-generator.h:555: unsigned type_;
make it a bit field with e.g. children_count_. This would allow us to save up to
8 bytes per entry on x64.

[loislo, 2012-05-22 17:08:09]

On 2012/05/22 16:47:03, alexeif wrote:
>
https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator.cc
> File src/profile-generator.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator....
> src/profile-generator.cc:1003: self_size(),  id(), indent, ' ', prefix,
> edge_name);
> nit: extra space

done

> 
>
https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator....
> src/profile-generator.cc:3344: 6 * MaxDecimalDigitsIn<sizeof(int)>::kSigned 
//
> NOLINT
> 6 -> 4
actually it has to be 5 * MaxDecimalDigitsIn<sizeof(uint32_t)>::kUnsigned

> 
>
https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator....
> src/profile-generator.cc:3346: + 7 + 1 + 1;
> 7 -> 5

done

> 
> https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator.h
> File src/profile-generator.h (right):
> 
>
https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator....
> src/profile-generator.h:487: int from_index_ : 29;
> Looks like we can kill from_index_ now. Isn't it?

It is using at the moment for building a continuous representation of node's
edges.

> 
>
https://chromiumcodereview.appspot.com/10416035/diff/1/src/profile-generator....
> src/profile-generator.h:555: unsigned type_;
> make it a bit field with e.g. children_count_. This would allow us to save up
to
> 8 bytes per entry on x64.

done

[alexeif, 2012-05-22 17:10:16]

lgtm

[mnaganov (inactive), 2012-05-22 19:50:31]

lgtm