Issue 10416028: Rename chromeos::input_method::kLeftControl to chromeos::input_method::kControl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10416028: Rename chromeos::input_method::kLeftControl to chromeos::input_method::kControl. (Closed)

Created:
8 years, 7 months ago by Yusuke Sato

Modified:
8 years, 7 months ago

Reviewers:
csilv, Zachary Kuznia

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename chromeos::input_method::kLeftControl to chromeos::input_method::kControl. The new name would be better since we support remapping the right control key. Do the same for chromeos::input_method::kLeftAlt. This cleanup is for issue 115112. BUG=115112 TEST=none TBR=csilv@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138449

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -37 lines)			Patch
M	chrome/browser/chromeos/input_method/xkeyboard.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/xkeyboard.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/xkeyboard_unittest.cc	View	4 chunks	+17 lines, -17 lines	0 comments	Download
M	chrome/browser/chromeos/preferences.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/keyboard_handler2.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 7 months ago (2012-05-23 07:35:36 UTC) #4

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/10416028/1

Expand Messages | Collapse Messages