Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10416026: Remove a bunch of RenderViewHostDelegate usage in chrome. I added a WebContents::FromRenderViewHost… (Closed)

Created:
8 years, 7 months ago by jam
Modified:
8 years, 7 months ago
Reviewers:
Jói
CC:
chromium-reviews, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, jochen+watch-content_chromium.org, tburkard+watch_chromium.org, yoshiki+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, mmenke, tfarina
Visibility:
Public.

Description

Remove a bunch of RenderViewHostDelegate usage in chrome. I added a WebContents::FromRenderViewHost which can be used instead of RenderViewHost::GetDelegate()->GetAsWebContents(). BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138254

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -46 lines) Patch
M chrome/browser/bookmarks/bookmark_manager_extension_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_processes_api.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/task_manager/task_manager_handler.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +5 lines, -0 lines 1 comment Download
M content/public/browser/render_view_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/view_type.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
8 years, 7 months ago (2012-05-22 02:41:29 UTC) #1
Jói
LGTM
8 years, 7 months ago (2012-05-22 15:10:42 UTC) #2
tfarina
8 years, 7 months ago (2012-05-22 15:28:07 UTC) #3 
https://chromiumcodereview.appspot.com/10416026/diff/1/content/browser/web_co...
File content/browser/web_contents/web_contents_impl.cc (right):

https://chromiumcodereview.appspot.com/10416026/diff/1/content/browser/web_co...
content/browser/web_contents/web_contents_impl.cc:254: WebContents*
WebContents::FromRenderViewHost(RenderViewHost* rvh) {
nit: // static

Powered by Google App Engine
This is Rietveld 408576698