Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: vm/flow_graph_compiler_x64.cc

Issue 10416025: Add a location summary to LoadLocal, StoreLocal and ConstantVal. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/flow_graph_compiler_x64.cc
===================================================================
--- vm/flow_graph_compiler_x64.cc (revision 7865)
+++ vm/flow_graph_compiler_x64.cc (working copy)
@@ -471,12 +471,14 @@
void FlowGraphCompiler::VisitUse(UseVal* val) {
- LoadValue(RAX, val);
+ // UseVal is never visited during code generation.
+ UNREACHABLE();
}
void FlowGraphCompiler::VisitConstant(ConstantVal* val) {
- LoadValue(RAX, val);
+ // Moved to intermediate_language_x64.cc.
+ UNREACHABLE();
}
@@ -663,13 +665,14 @@
void FlowGraphCompiler::VisitLoadLocal(LoadLocalComp* comp) {
- __ movq(RAX, Address(RBP, comp->local().index() * kWordSize));
+ // Moved to intermediate_language_x64.cc.
+ UNREACHABLE();
}
void FlowGraphCompiler::VisitStoreLocal(StoreLocalComp* comp) {
- LoadValue(RAX, comp->value());
- __ movq(Address(RBP, comp->local().index() * kWordSize), RAX);
+ // Moved to intermediate_language_x64.cc.
+ UNREACHABLE();
}
« no previous file with comments | « no previous file | vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698