Desktop aura: Put x11 cache in aura, instead of ui/base/x/.

Desktop aura: Put x11 cache in aura, instead of ui/base/x/.

This should solve the pyauto compile error because MessagePumpX is actually an aura component, not a general x11 component.

Instead of being a Singleton, X11AtomCache should tie its lifetime to an aura::Env, which are reset in the unit tests whenever an X server is switched out.

BUG=128584, 129075
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138290

[Daniel Erat, 2012-05-21 22:49:43]

lgtm

https://chromiumcodereview.appspot.com/10416020/diff/4001/ui/aura/aura.gyp
File ui/aura/aura.gyp (right):

https://chromiumcodereview.appspot.com/10416020/diff/4001/ui/aura/aura.gyp#ne...
ui/aura/aura.gyp:113: 'x11_atom_cache.cc',
do we already filter out the x11_ prefix (in addition to the _x11 suffix) on
non-X platforms?

https://chromiumcodereview.appspot.com/10416020/diff/4001/ui/aura/x11_atom_ca...
File ui/aura/x11_atom_cache.cc (right):

https://chromiumcodereview.appspot.com/10416020/diff/4001/ui/aura/x11_atom_ca...
ui/aura/x11_atom_cache.cc:18: aura::AtomName id;
nit: shouldn't need the aura:: qualifier here

https://chromiumcodereview.appspot.com/10416020/diff/4001/ui/aura/x11_atom_ca...
ui/aura/x11_atom_cache.cc:30: COMPILE_ASSERT(arraysize(kAtomList) ==
aura::ATOM_COUNT,
or here

[Elliot Glaysher, 2012-05-21 22:54:44]

+sadrul: we also need to tie the atom cache to the lifetime of Env. Otherwise,
we could do it like your comment on the bug.

https://chromiumcodereview.appspot.com/10416020/diff/4001/ui/aura/aura.gyp
File ui/aura/aura.gyp (right):

https://chromiumcodereview.appspot.com/10416020/diff/4001/ui/aura/aura.gyp#ne...
ui/aura/aura.gyp:113: 'x11_atom_cache.cc',
On 2012/05/21 22:49:43, Daniel Erat wrote:
> do we already filter out the x11_ prefix (in addition to the _x11 suffix) on
> non-X platforms?

Yes. In filename_rules.gypi, there's a rule that filters out anything that
starts with x11_ if use_x11!=1

[sadrul, 2012-05-21 23:04:30]

LGTM

[commit-bot: I haz the power, 2012-05-21 23:18:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/10416020/10002

[commit-bot: I haz the power, 2012-05-21 23:19:07]

Presubmit check for 10416020-10002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ui/aura
    ui

Presubmit checks took 1.8s to calculate.

[Elliot Glaysher, 2012-05-21 23:19:44]

+sky for stamp

[sky, 2012-05-22 00:00:16]

LGTM

[commit-bot: I haz the power, 2012-05-22 00:00:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/10416020/10002

[commit-bot: I haz the power, 2012-05-22 02:49:06]

Try job failure for 10416020-10002 (retry) on win_rel for steps "base_unittests,
sync_unit_tests".
It's a second try, previously, steps "base_unittests, sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...