Chromium Code Reviews| Index: SConstruct |
| =================================================================== |
| --- SConstruct (revision 8659) |
| +++ SConstruct (working copy) |
| @@ -3416,8 +3416,13 @@ |
| nacl_env.AddMethod(NaClSharedLibrary) |
| def NaClSdkLibrary(env, lib_name, *args, **kwargs): |
| + gen_shared = not env.Bit('nacl_disable_shared') |
| + if 'no_shared_lib' in kwargs: |
| + if kwargs['no_shared_lib']: |
|
jvoung - send to chromium...
2012/05/22 20:49:40
Can't you still add a arg with a default value, in
Robert Muth (chromium)
2012/05/22 21:16:36
Sadly you cannot mix args that way in python
The o
jvoung - send to chromium...
2012/05/22 23:22:13
Well it worked on a simple example I tried, but th
|
| + gen_shared = False |
| + del kwargs['no_shared_lib'] |
| n = [env.ComponentLibrary(lib_name, *args, **kwargs)] |
| - if not env.Bit('nacl_disable_shared'): |
| + if gen_shared: |
| n.append(NaClSharedLibrary(env, lib_name, *args, **kwargs)) |
| return n |