Issue 10416005: Some cleanup to common.gypi. This fixes some host/target combinations that weren't working in the M…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10416005: Some cleanup to common.gypi. This fixes some host/target combinations that weren't working in the M… (Closed)

Created:
8 years, 7 months ago by Jakob Kummerow

Modified:
8 years, 7 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Some cleanup to common.gypi. This fixes some host/target combinations that weren't working in the Make build on Mac. Committed: https://code.google.com/p/v8/source/detail?r=11617

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -123 lines)			Patch
	M	build/common.gypi	View		6 chunks	+102 lines, -123 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Please take a look. This looks worse than it is: the bulk of the changes ...

8 years, 7 months ago (2012-05-21 09:30:46 UTC) #1

Yang

8 years, 7 months ago (2012-05-21 09:42:54 UTC) #2

On 2012/05/21 09:30:46, Jakob wrote:
> Please take a look.
> 
> This looks worse than it is: the bulk of the changes is an indentation change
> that the diff view doesn't recognize. Happy to talk you through the CL
offline.

LGTM.

Expand Messages | Collapse Messages