Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: net/socket/client_socket_pool_base_unittest.cc

Issue 10414082: Disable ClientSocketPoolBaseTest.RequestSocketsMultipleTimesDoesNothing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: "" Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_pool_base_unittest.cc
diff --git a/net/socket/client_socket_pool_base_unittest.cc b/net/socket/client_socket_pool_base_unittest.cc
index 3f9c4eca4d28c6bc05fce1637e6cec78da9a7e5f..078735e506a2b28100985ee51da71e108418f710 100644
--- a/net/socket/client_socket_pool_base_unittest.cc
+++ b/net/socket/client_socket_pool_base_unittest.cc
@@ -3243,7 +3243,17 @@ TEST_F(ClientSocketPoolBaseTest, RequestSocketsSynchronousError) {
ASSERT_FALSE(pool_->HasGroup("a"));
}
-TEST_F(ClientSocketPoolBaseTest, RequestSocketsMultipleTimesDoesNothing) {
+// http://crbug.com/129364
+#if defined(OS_WIN)
+#define MAYBE_RequestSocketsMultipleTimesDoesNothing \
+ DISABLED_RequestSocketsMultipleTimesDoesNothing
+#else
+#define MAYBE_RequestSocketsMultipleTimesDoesNothing \
+ RequestSocketsMultipleTimesDoesNothing
+#endif
+
+TEST_F(ClientSocketPoolBaseTest,
+ MAYBE_RequestSocketsMultipleTimesDoesNothing) {
CreatePool(4, 4);
connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698