Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: chrome/browser/browser_keyevents_browsertest.cc

Issue 10414060: Disable tests broken by WK r118001 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Copy/paste glitch Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_keyevents_browsertest.cc
diff --git a/chrome/browser/browser_keyevents_browsertest.cc b/chrome/browser/browser_keyevents_browsertest.cc
index 33f258040ac129ed655e97217c180b12542cbaf0..568a669a906abe75daad51890af92c1aa85ae78f 100644
--- a/chrome/browser/browser_keyevents_browsertest.cc
+++ b/chrome/browser/browser_keyevents_browsertest.cc
@@ -293,6 +293,9 @@ class BrowserKeyEventsTest : public InProcessBrowserTest {
#if defined(OS_MACOSX)
// http://crbug.com/81451
IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, DISABLED_NormalKeyEvents) {
+#elif defined(OS_LINUX)
vandebo (ex-Chrome) 2012/05/22 23:03:49 This stuff is more commonly done with a MAYBE patt
jsbell 2012/05/22 23:18:12 Yeah, initially I wanted a less intrusive change b
+// http://crbug.com/129235
+IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, FAILS_NormalKeyEvents) {
#else
IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, NormalKeyEvents) {
#endif
@@ -392,7 +395,12 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, NormalKeyEvents) {
}
#if defined(OS_WIN) || defined(OS_LINUX)
+#if defined(OS_LINUX)
+// http://crbug.com/129235
+IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, FAILS_CtrlKeyEvents) {
+#else
IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, CtrlKeyEvents) {
+#endif
static const KeyEventTestData kTestCtrlF = {
ui::VKEY_F, true, false, false, false,
false, false, false, false, 2,
@@ -515,6 +523,9 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, DISABLED_CommandKeyEvents) {
#if defined(OS_MACOSX)
// http://crbug.com/81451 for mac
IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, DISABLED_AccessKeys) {
+#elif defined(OS_LINUX)
+// http://crbug.com/129235
+IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, FAILS_AccessKeyEvents) {
#else
IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, AccessKeys) {
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698