Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 10414060: Disable tests broken by WK r118001 (Closed)

Created:
8 years, 7 months ago by jsbell
Modified:
8 years, 7 months ago
CC:
chromium-reviews, tasak
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Copy/paste glitch #

Total comments: 2

Patch Set 3 : Use MAYBE style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M chrome/browser/browser_keyevents_browsertest.cc View 1 2 3 chunks +22 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/10414060/1
8 years, 7 months ago (2012-05-22 22:27:36 UTC) #1
commit-bot: I haz the power
Try job failure for 10414060-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-22 22:56:55 UTC) #2
vandebo (ex-Chrome)
https://chromiumcodereview.appspot.com/10414060/diff/9002/chrome/browser/browser_keyevents_browsertest.cc File chrome/browser/browser_keyevents_browsertest.cc (right): https://chromiumcodereview.appspot.com/10414060/diff/9002/chrome/browser/browser_keyevents_browsertest.cc#newcode296 chrome/browser/browser_keyevents_browsertest.cc:296: #elif defined(OS_LINUX) This stuff is more commonly done with ...
8 years, 7 months ago (2012-05-22 23:03:48 UTC) #3
jsbell
https://chromiumcodereview.appspot.com/10414060/diff/9002/chrome/browser/browser_keyevents_browsertest.cc File chrome/browser/browser_keyevents_browsertest.cc (right): https://chromiumcodereview.appspot.com/10414060/diff/9002/chrome/browser/browser_keyevents_browsertest.cc#newcode296 chrome/browser/browser_keyevents_browsertest.cc:296: #elif defined(OS_LINUX) On 2012/05/22 23:03:49, vandebo wrote: > This ...
8 years, 7 months ago (2012-05-22 23:18:12 UTC) #4
vandebo (ex-Chrome)
8 years, 7 months ago (2012-05-22 23:20:35 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698