Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 10414027: fix location of warning disable for leveldb (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

fix location of warning disable for leveldb Was added in wrong location in https://chromiumcodereview.appspot.com/10384092/ and apparently not very thoroughly tested. :/ R=thakis@chromium.org BUG=126483 NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/leveldatabase/leveldatabase.gyp View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
8 years, 7 months ago (2012-05-21 21:46:07 UTC) #1
Nico
review muppet says lgtm like last time. so chances are it's wrong AGAIN
8 years, 7 months ago (2012-05-21 21:59:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10414027/1
8 years, 7 months ago (2012-05-21 22:02:13 UTC) #3
commit-bot: I haz the power
Try job failure for 10414027-1 (retry) (previous was lost) on win_rel for steps "base_unittests, sync_unit_tests". ...
8 years, 7 months ago (2012-05-22 02:46:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10414027/1
8 years, 7 months ago (2012-05-22 16:33:35 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 16:36:19 UTC) #6
Change committed as 138272

Powered by Google App Engine
This is Rietveld 408576698