runtime/vm/stub_code_ia32.cc - Issue 10414026: Started porting inlined type checks to x64 (will be the future pattern for other architectures).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 10414026: Started porting inlined type checks to x64 (will be the future pattern for other architectures). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_ia32.cc

===================================================================

--- runtime/vm/stub_code_ia32.cc (revision 7823)

+++ runtime/vm/stub_code_ia32.cc (working copy)

@@ -1801,7 +1801,6 @@

const intptr_t kCacheOffsetInBytes = 3 * kWordSize;

const Immediate raw_null =

Immediate(reinterpret_cast<intptr_t>(Object::null()));

- Label not_found;

__ movl(EAX, Address(ESP, kInstanceOffsetInBytes));

__ movl(ECX, FieldAddress(EAX, Object::class_offset()));

// EAX: instance, ECX: instance-class.

@@ -1817,13 +1816,13 @@

__ movl(EBX, FieldAddress(EAX, EDI, TIMES_1, 0));

__ Bind(&has_no_type_arguments);

}

- // EBX: instance type arguments (null if none).

+ // EBX: instance type arguments (null if none), used only if n > 1.

__ movl(EDX, Address(ESP, kCacheOffsetInBytes));

// EDX: SubtypeTestCache.

__ movl(EDX, FieldAddress(EDX, SubtypeTestCache::cache_offset()));

__ addl(EDX, Immediate(Array::data_offset() - kHeapObjectTag));

- Label loop, found, next_iteration;

+ Label loop, found, not_found, next_iteration;

// EDX: Entry start.

// ECX: instance class.

// EBX: instance type arguments

« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »