Started porting inlined type checks to x64 (will be the future pattern for other architectures).

runtime/vm/code_generator_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/code_generator.h"
 
 #include "lib/error.h"
@@ skipping 1214 matching lines @@
     intptr_t node_id,
     intptr_t token_index,
     const Class& type_class,
     Label* is_instance_lbl,
     Label* is_not_instance_lbl) {
   const SubtypeTestCache& type_test_cache =
       SubtypeTestCache::ZoneHandle(SubtypeTestCache::New());
   const Bool& bool_true = Bool::ZoneHandle(Bool::True());
   const Immediate raw_null =
       Immediate(reinterpret_cast<intptr_t>(Object::null()));
-  Label loop, found_in_cache, runtime_call;
   // Check immediate equality.
   __ movl(ECX, FieldAddress(EAX, Object::class_offset()));
   // ECX: instance class.
   __ CompareObject(ECX, type_class);
   __ j(EQUAL, is_instance_lbl);
 
   // Check immediate superclass equality.
   __ movl(EDI, FieldAddress(ECX, Class::super_type_offset()));
   __ movl(EDI, FieldAddress(EDI, Type::type_class_offset()));
   __ CompareObject(EDI, type_class);
   __ j(EQUAL, is_instance_lbl);
 
   __ LoadObject(EDX, type_test_cache);
   __ pushl(EDX);  // Cache array.
   __ pushl(EAX);  // Instance.
   __ pushl(raw_null);  // Unused
   __ call(&StubCode::Subtype1TestCacheLabel());
   __ popl(EAX);  // Discard.
   __ popl(EAX);  // Restore receiver.
   __ popl(EDX);  // Discard.
   // Result is in ECX: null -> not found, otherwise Bool::True or Bool::False.
 
+  Label runtime_call;
   __ cmpl(ECX, raw_null);
   __ j(EQUAL, &runtime_call, Assembler::kNearJump);
   __ CompareObject(ECX, bool_true);
   __ j(EQUAL, is_instance_lbl);
   __ jmp(is_not_instance_lbl);
   __ Bind(&runtime_call);
   return type_test_cache.raw();
 }
 
 
@@ skipping 180 matching lines @@
   // non-parameterized class or with a raw dst type of a parameterized class.
   __ testl(EAX, Immediate(kSmiTagMask));
   __ j(ZERO, is_not_instance_lbl);
   const AbstractTypeArguments& type_arguments =
       AbstractTypeArguments::ZoneHandle(type.arguments());
   const bool is_raw_type = type_arguments.IsNull() ||
       type_arguments.IsRaw(type_arguments.Length());
   if (is_raw_type) {
     // Dynamic type argument, check only classes.
     __ movl(ECX, FieldAddress(EAX, Object::class_offset()));
+    if (!type_class.is_interface()) {
+      __ CompareObject(ECX, type_class);
+      __ j(EQUAL, is_instance_lbl);
+    }
     if (type.IsListInterface()) {
       // TODO(srdjan) also accept List<Object>.
       __ CompareObject(ECX, *CoreClass("ObjectArray"));
       __ j(EQUAL, is_instance_lbl);
       __ CompareObject(ECX, *CoreClass("GrowableObjectArray"));
       __ j(EQUAL, is_instance_lbl);
     }
     return
         GenerateSubtype1TestCacheLookup(node_id, token_index, type_class,
                                         is_instance_lbl, is_not_instance_lbl);
@@ skipping 78 matching lines @@
 
   // Checking against interface.
   // However, for specific core library interfaces, we can check for
   // specific core library classes.
   if (type.IsBoolInterface()) {
     __ movl(ECX, FieldAddress(EAX, Object::class_offset()));
     const Class& bool_class = Class::ZoneHandle(
         Isolate::Current()->object_store()->bool_class());
     __ CompareObject(ECX, bool_class);
     __ j(EQUAL, is_instance_lbl);
+    __ jmp(is_not_instance_lbl);
     return;
   }
   // If type is an interface, we can skip the class equality check,
   // because instances cannot be of an interface type.
   if (!type_class.is_interface()) {
     __ movl(ECX, FieldAddress(EAX, Object::class_offset()));
     __ CompareObject(ECX, type_class);
     __ j(EQUAL, is_instance_lbl);
   }
   if (type.IsSubtypeOf(
         Type::Handle(Type::NumberInterface()), &malformed_error)) {
     // Custom checking for numbers (Smi, Mint, Bigint and Double)
     __ movl(ECX, FieldAddress(EAX, Object::class_offset()));
     if (type.IsIntInterface() || type.IsNumberInterface()) {
       // We already checked for Smi above.
       const Class& mint_class = Class::ZoneHandle(
           Isolate::Current()->object_store()->mint_class());
       const Class& bigint_class = Class::ZoneHandle(
           Isolate::Current()->object_store()->bigint_class());
       __ CompareObject(ECX, mint_class);
       __ j(EQUAL, is_instance_lbl);
       __ CompareObject(ECX, bigint_class);
       __ j(EQUAL, is_instance_lbl);
+      if (type.IsIntInterface()) {
+        __ jmp(is_not_instance_lbl);
+      }
     }
     if (type.IsDoubleInterface() || type.IsNumberInterface()) {
       const Class& double_class = Class::ZoneHandle(
           Isolate::Current()->object_store()->double_class());
       __ CompareObject(ECX, double_class);
       __ j(EQUAL, is_instance_lbl);
+      __ jmp(is_not_instance_lbl);
     }
   } else if (type.IsStringInterface()) {
     __ movl(ECX, FieldAddress(EAX, Object::class_offset()));
     const Class& one_byte_string_class = Class::ZoneHandle(
         Isolate::Current()->object_store()->one_byte_string_class());
     const Class& two_byte_string_class = Class::ZoneHandle(
         Isolate::Current()->object_store()->two_byte_string_class());
     const Class& four_byte_string_class = Class::ZoneHandle(
         Isolate::Current()->object_store()->four_byte_string_class());
     __ CompareObject(ECX, one_byte_string_class);
@@ skipping 1379 matching lines @@
   const Error& error = Error::Handle(
       Parser::FormatError(script, token_index, "Error", format, args));
   va_end(args);
   Isolate::Current()->long_jump_base()->Jump(1, error);
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32