Service state file processing

Validates service state file and ask user to update information if necessarily.
Connects to Google servers to get authentication tokens.

BUG=125026
TEST=service_state_unittest.cc

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138294

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138371

[gene, 2012-05-21 23:08:06]

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
File cloud_print/service/win/cloud_print_service.cc (right):

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
cloud_print/service/win/cloud_print_service.cc:270: std::cout << file.value() <<
":\n";
if (!quiet) - ???

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
cloud_print/service/win/cloud_print_service.cc:280: std::cout << "Do you want to
use this file [y/n]:";
If file is not valid, shall we ask user before overwriting it?
Or may be it make sense to add a command line key which will trigger config file
creation?

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
cloud_print/service/win/cloud_print_service.cc:296: is_valid =
service_state.Configure(&delegate);
Can we call GetOption() here, and then Configure(email,password,id), instead of
current round trip?

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
File cloud_print/service/win/service_state.cc (right):

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
cloud_print/service/win/service_state.cc:55: if (!request->Read(buf, kBufSize,
&num_bytes)) {
from url_request.h

  // Read() must be called at least once. Read() returns true when it completed
  // immediately, and false if an IO is pending or if there is an error.  When
  // Read() returns false, the caller can check the Request's status() to see
  // if an error occurred, or if the IO is just pending.  When Read() returns
  // true with zero bytes read, it indicates the end of the response.

[gene, 2012-05-21 23:18:37]

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
File cloud_print/service/win/service_state.cc (right):

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
cloud_print/service/win/service_state.cc:163: GURL
url("https://www.google.com/accounts/ClientLogin");
Move this to consts in the begining of the file.

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
cloud_print/service/win/service_state.cc:207: xmpp_auth_token_ =
LoginToGoogle("chromiumsync", email_, password_);
You need to clear robot accounts here, otherwise it will not work.

[Vitaly Buka (NO REVIEWS), 2012-05-22 05:47:19]

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
File cloud_print/service/win/cloud_print_service.cc (right):

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
cloud_print/service/win/cloud_print_service.cc:270: std::cout << file.value() <<
":\n";
On 2012/05/21 23:08:06, gene wrote:
> if (!quiet) - ???

Done.

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
cloud_print/service/win/cloud_print_service.cc:280: std::cout << "Do you want to
use this file [y/n]:";
On 2012/05/21 23:08:06, gene wrote:
> If file is not valid, shall we ask user before overwriting it?
> Or may be it make sense to add a command line key which will trigger config
file
> creation?

Done.

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
cloud_print/service/win/cloud_print_service.cc:296: is_valid =
service_state.Configure(&delegate);
On 2012/05/21 23:08:06, gene wrote:
> Can we call GetOption() here, and then Configure(email,password,id), instead
of
> current round trip?

Done.

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
File cloud_print/service/win/service_state.cc (right):

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
cloud_print/service/win/service_state.cc:55: if (!request->Read(buf, kBufSize,
&num_bytes)) {
On 2012/05/21 23:08:06, gene wrote:
> from url_request.h
> 
>   // Read() must be called at least once. Read() returns true when it
completed
>   // immediately, and false if an IO is pending or if there is an error.  When
>   // Read() returns false, the caller can check the Request's status() to see
>   // if an error occurred, or if the IO is just pending.  When Read() returns
>   // true with zero bytes read, it indicates the end of the response.

Done.

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
cloud_print/service/win/service_state.cc:163: GURL
url("https://www.google.com/accounts/ClientLogin");
On 2012/05/21 23:18:37, gene wrote:
> Move this to consts in the begining of the file.

Done.

https://chromiumcodereview.appspot.com/10414020/diff/13001/cloud_print/servic...
cloud_print/service/win/service_state.cc:207: xmpp_auth_token_ =
LoginToGoogle("chromiumsync", email_, password_);
On 2012/05/21 23:18:37, gene wrote:
> You need to clear robot accounts here, otherwise it will not work.

Done.

[gene, 2012-05-22 17:48:02]

lgtm

[commit-bot: I haz the power, 2012-05-22 18:00:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10414020/13

[commit-bot: I haz the power, 2012-05-22 21:53:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10414020/24002

[commit-bot: I haz the power, 2012-05-22 21:57:24]

Try job failure for 10414020-24002 (retry) on mac_rel for step "update".
It's a second try, previously, step "update" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.