Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10414017: RefCounted types should not have public destructors (Closed)

Created:
8 years, 7 months ago by Ryan Sleevi
Modified:
8 years, 7 months ago
Reviewers:
battre
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

RefCounted types should not have public destructors BUG=123295 TEST=none TBR=battre@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ryan Sleevi
TBR - one regression that slipped in blocking me from landing http://codereview.chromium.org/10414016/
8 years, 7 months ago (2012-05-19 05:18:10 UTC) #1
battre
8 years, 7 months ago (2012-05-19 08:19:56 UTC) #2 
LGTM, thanks

Dominic

Powered by Google App Engine
This is Rietveld 408576698