Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9294)

Unified Diff: build/common.gypi

Issue 10414016: Enable warnings for having RefCounted types with a public destructor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add a note Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/scripts/plugin_flags.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 8985bb6eb5aaaa9b28d3873f5b0b5669aa5fe364..7f724e65000d44532b1b5e1beab538d12fe017be 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1089,8 +1089,28 @@
'grit_defines': ['-D', 'enable_extensions'],
}],
['clang_use_chrome_plugins==1 and OS!="win"', {
- 'clang_chrome_plugins_flags':
- '<!(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)',
+ 'variables': {
+ 'clang_chrome_plugins_flags': [
+ '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'
+ ],
+ },
+ 'conditions': [
+ ['chromeos==1', {
+ # TODO(rsleevi): http://crbug.com/123295 - Disabled on ChromeOS
+ # for now.
+ 'clang_chrome_plugins_flags': [
+ '<@(clang_chrome_plugins_flags)',
+ '-Xclang',
+ '-plugin-arg-find-bad-constructs',
+ '-Xclang',
+ '-skip-refcounted-dtors'
+ ],
+ }, {
+ 'clang_chrome_plugins_flags': [
+ '<@(clang_chrome_plugins_flags)',
+ ],
+ }],
+ ],
}],
# Set use_ibus to 1 to enable ibus support.
@@ -2191,7 +2211,7 @@
}],
['clang==1 and clang_use_chrome_plugins==1', {
'cflags': [
- '<(clang_chrome_plugins_flags)',
+ '<@(clang_chrome_plugins_flags)',
],
}],
['clang==1 and clang_load!=""', {
@@ -2626,7 +2646,7 @@
}],
['clang==1 and clang_use_chrome_plugins==1', {
'OTHER_CFLAGS': [
- '<(clang_chrome_plugins_flags)',
+ '<@(clang_chrome_plugins_flags)',
],
}],
['clang==1 and clang_load!=""', {
« no previous file with comments | « no previous file | tools/clang/scripts/plugin_flags.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698