Issue 10414016: Enable warnings for having RefCounted types with a public destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10414016: Enable warnings for having RefCounted types with a public destructor. (Closed)

Created:
8 years, 7 months ago by Ryan Sleevi

Modified:
8 years, 7 months ago

Reviewers:
Nico, (unused - use chromium)

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable warnings for having RefCounted types with a public destructor. Enable the Clang error that makes it a warning/error to derive from base::RefCounted/RefCountedThreadSafe directly and have a public destructor for Linux and Mac builds. For ChromeOS builds, do not yet enable the warning, as it does not yet build cleanly. BUG=123295 TEST=it compiles R=thakis Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138031

Patch Set 1 #

Patch Set 2 : Add a note #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -5 lines)			Patch
	M	build/common.gypi	View	1	3 chunks	+24 lines, -4 lines	0 comments	Download
	M	tools/clang/scripts/plugin_flags.sh	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

Nico: PTAL. I've been asked to hold off on CrOS for a while due to ...

8 years, 7 months ago (2012-05-19 01:49:14 UTC) #1

Nico

lgtm, congrats :-) (Looks like another violation was introduced in the meantime.) Please update http://dev.chromium.org/developers/coding-style/chromium-style-checker-errors ...

8 years, 7 months ago (2012-05-19 03:28:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10414016/2001

8 years, 7 months ago (2012-05-19 05:19:16 UTC) #3

Change committed as 138031

Expand Messages | Collapse Messages