Issue 10414011: [NaCl SDK] Some fixes to update_nacl_manifest.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10414011: [NaCl SDK] Some fixes to update_nacl_manifest.py. (Closed)

Created:
8 years, 7 months ago by binji

Modified:
8 years, 7 months ago

Reviewers:
noelallen1

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Some fixes to update_nacl_manifest.py. Also modified naclsdk_manifest2.json to allow update_nacl_manifest to upload pepper_20 bundles. BUG=none TEST=tests/test_update_manifest.py Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138169

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -44 lines)			Patch
M	native_client_sdk/src/build_tools/build_sdk.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	native_client_sdk/src/build_tools/json/naclsdk_manifest2.json	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	native_client_sdk/src/build_tools/tests/test_update_manifest.py	View	5 chunks	+30 lines, -10 lines	0 comments	Download
M	native_client_sdk/src/build_tools/update_nacl_manifest.py	View	4 chunks	+19 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages