Teaching BrowsingDataRemover how to delete application data.

chrome/browser/browsing_data_remover.h

Index: chrome/browser/browsing_data_remover.h
diff --git a/chrome/browser/browsing_data_remover.h b/chrome/browser/browsing_data_remover.h
index c34db65ade7be003da2d66a253fe71e4e1292e1c..2e6a88c387c963794026975468e0c99e1308e641 100644
--- a/chrome/browser/browsing_data_remover.h
+++ b/chrome/browser/browsing_data_remover.h
@@ -57,6 +57,11 @@ class BrowsingDataRemover : public content::NotificationObserver,
     EVERYTHING
   };
 
+  enum RemoveOriginSet {
+    REMOVE_FROM_UNPROTECTED_ORIGINS,
+    REMOVE_FROM_ALL_ORIGINS
+  };
+
   // Mask used for Remove.
   enum RemoveDataMask {
     REMOVE_APPCACHE = 1 << 0,
@@ -120,7 +125,7 @@ class BrowsingDataRemover : public content::NotificationObserver,
                       base::Time delete_end);
 
   // Removes the specified items related to browsing for all origins.
-  void Remove(int remove_mask);
+  void Remove(int remove_mask, RemoveOriginSet origin_set);

[Bernhard Bauer, 2012/05/23 11:13:11]

Is there a reason you're not just passing in a bool |include_protected_origins|?

[Mike West, 2012/05/23 11:23:51]

Magic booleans are confusing in a public API. *shrug*  If you saw
`remover_->remove(true);`, you don't understand the impact as well as you do if
there's something descriptive there.

[Bernhard Bauer, 2012/05/23 11:31:40]

Right; what I usually do in that case is something like:

  bool include_all_origins = true;
  remover->remove(include_all_origins);

The advantage of seeing that the value is a single bit is that you immediately
know what the possible values are. If you see |REMOVE_FROM_UNPROTECTED_ORIGINS|,
it's not clear what the alternative values would be (or mean).

 
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);