Teaching BrowsingDataRemover how to delete application data.

webkit/dom_storage/dom_storage_context.cc

Index: webkit/dom_storage/dom_storage_context.cc
diff --git a/webkit/dom_storage/dom_storage_context.cc b/webkit/dom_storage/dom_storage_context.cc
index e31019067cea7b9922f5e894dd30e741c1d0b5c9..b74d0eb7ec066ba6f44733be81d52a93b29a54a6 100644
--- a/webkit/dom_storage/dom_storage_context.cc
+++ b/webkit/dom_storage/dom_storage_context.cc
@@ -95,13 +95,15 @@ void DomStorageContext::DeleteOrigin(const GURL& origin) {
   local->DeleteOrigin(origin);
 }
 
-void DomStorageContext::DeleteDataModifiedSince(const base::Time& cutoff) {
+void DomStorageContext::DeleteDataModifiedSince(const base::Time& cutoff,
+    bool include_protected_origins) {

[jochen (gone - plz use gerrit), 2012/05/23 11:02:21]

nit. all arguments on their own line

[Mike West, 2012/05/23 11:23:51]

Done.

   std::vector<UsageInfo> infos;
   const bool kIncludeFileInfo = true;
   GetUsageInfo(&infos, kIncludeFileInfo);
   for (size_t i = 0; i < infos.size(); ++i) {
     if (infos[i].last_modified > cutoff) {
-      if (!special_storage_policy_ ||
+      if (include_protected_origins ||
+          !special_storage_policy_ ||
           !special_storage_policy_->IsStorageProtected(infos[i].origin)) {

[jochen (gone - plz use gerrit), 2012/05/23 11:02:21]

this will also delete data on chrome-extensions://

is that really intended, or do you just want to delete data on http/https
origins that are covered by app extends?

[Mike West, 2012/05/23 11:23:51]

My understanding of the feature was that it should kill all application data,
which in my mind includes everything installed in the browser. It kills devtools
data too at the moment; that's intentional on my part, but I guess it's up for
debate whether that's what the checkbox means.

[jochen (gone - plz use gerrit), 2012/05/23 11:38:36]

ok, if that's the desired behavior meanwhile. We used to do that in the
beginning in it caused a certain level of drama.

         DeleteOrigin(infos[i].origin);
       }