Teaching BrowsingDataRemover how to delete application data.

content/public/browser/dom_storage_context.h

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_DOM_STORAGE_CONTEXT_H_
 #define CONTENT_PUBLIC_BROWSER_DOM_STORAGE_CONTEXT_H_
 #pragma once
 
 #include <vector>
 
 #include "base/callback.h"
 #include "base/string16.h"
 #include "content/common/content_export.h"
 
 class FilePath;
 
 namespace base {
 class Time;
 }
 
 namespace content {
 
 class BrowserContext;
 
 // Represents the per-BrowserContext Local Storage data.
 class DOMStorageContext {
  public:
   typedef base::Callback<void(const std::vector<FilePath>&)>
       GetAllStorageFilesCallback;

[michaeln, 2012/05/31 22:49:07]

Can you add the following to this interface and use them from the BDR instead of
the FilePath and origin_id string based interfaces. I can come back later and
delete other usages of the FilePath/origin_id cruft later.

  typedef base::Callback<void(const std::vector<UsageInfo >&)>
      GetUsageInfoCallback;

  struct UsageInfo {
    GURL origin;
    size_t data_size;
    base::Time last_modified;

    UsageInfo();
    ~UsageInfo();
  };

  virtual void GetUsageInfo(const GetUsageInfoCallback& callback) = 0;
  virtual void DeleteOrigin(const GURL& origin) = 0;

[Mike West, 2012/06/01 13:35:17]

You're taking care of this in http://codereview.chromium.org/10449103/, for
which you've become my single most favoritest engineer of the week. :)

 
   // Returns all the file paths of local storage files to the given callback.
   virtual void GetAllStorageFiles(
       const GetAllStorageFilesCallback& callback) = 0;
 
   // Get the file name of the local storage file for the given origin.
   virtual FilePath GetFilePath(const string16& origin_id) const = 0;
 
   // Deletes the local storage file for the given origin.
   virtual void DeleteForOrigin(const string16& origin_id) = 0;
 
   // Deletes a single local storage file.
   virtual void DeleteLocalStorageFile(const FilePath& file_path) = 0;
 
-  // Delete any local storage files that have been touched since the cutoff
-  // date that's supplied. Protected origins, per the SpecialStoragePolicy,
-  // are not deleted by this method.
-  virtual void DeleteDataModifiedSince(const base::Time& cutoff) = 0;
-
  protected:
   virtual ~DOMStorageContext() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_DOM_STORAGE_CONTEXT_H_