Teaching BrowsingDataRemover how to delete application data.

chrome/browser/browsing_data_remover.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BROWSING_DATA_REMOVER_H_
 #define CHROME_BROWSER_BROWSING_DATA_REMOVER_H_
 #pragma once
 
 #include <set>
 
@@ skipping 39 matching lines @@
  public:
   // Time period ranges available when doing browsing data removals.
   enum TimePeriod {
     LAST_HOUR = 0,
     LAST_DAY,
     LAST_WEEK,
     FOUR_WEEKS,
     EVERYTHING
   };
 
+  enum RemoveOriginSet {
+    REMOVE_FROM_UNPROTECTED_ORIGINS,
+    REMOVE_FROM_ALL_ORIGINS
+  };
+
   // Mask used for Remove.
   enum RemoveDataMask {
     REMOVE_APPCACHE = 1 << 0,
     REMOVE_CACHE = 1 << 1,
     REMOVE_COOKIES = 1 << 2,
     REMOVE_DOWNLOADS = 1 << 3,
     REMOVE_FILE_SYSTEMS = 1 << 4,
     REMOVE_FORM_DATA = 1 << 5,
     // In addition to visits, REMOVE_HISTORY removes keywords and last session.
     REMOVE_HISTORY = 1 << 6,
@@ skipping 43 matching lines @@
   // profile in the specified time range. Use Remove to initiate the removal.
   BrowsingDataRemover(Profile* profile, base::Time delete_begin,
                       base::Time delete_end);
 
   // Creates a BrowsingDataRemover to remove browser data from the specified
   // profile in the specified time range.
   BrowsingDataRemover(Profile* profile, TimePeriod time_period,
                       base::Time delete_end);
 
   // Removes the specified items related to browsing for all origins.
-  void Remove(int remove_mask);
+  void Remove(int remove_mask, RemoveOriginSet origin_set);

[Bernhard Bauer, 2012/05/23 11:13:11]

Is there a reason you're not just passing in a bool |include_protected_origins|?

[Mike West, 2012/05/23 11:23:51]

Magic booleans are confusing in a public API. *shrug*  If you saw
`remover_->remove(true);`, you don't understand the impact as well as you do if
there's something descriptive there.

[Bernhard Bauer, 2012/05/23 11:31:40]

Right; what I usually do in that case is something like:

  bool include_all_origins = true;
  remover->remove(include_all_origins);

The advantage of seeing that the value is a single bit is that you immediately
know what the possible values are. If you see |REMOVE_FROM_UNPROTECTED_ORIGINS|,
it's not clear what the alternative values would be (or mean).

 
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
   // Called when history deletion is done.
   void OnHistoryDeletionDone();
 
   // Quota managed data uses a different bitmask for types than
   // BrowsingDataRemover uses. This method generates that mask.
   static int GenerateQuotaClientMask(int remove_mask);
@@ skipping 186 matching lines @@
 
   ObserverList<Observer> observer_list_;
 
   // Used if we need to clear history.
   CancelableRequestConsumer request_consumer_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowsingDataRemover);
 };
 
 #endif  // CHROME_BROWSER_BROWSING_DATA_REMOVER_H_