More strict check for IBusPanelService.

Check more strictly for IBusPanelService.

According to this CL, we can avoid invalid object casting or signal disconnection.

BUG=129142
TEST=manually on Alex.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138480

[Yusuke Sato, 2012-05-23 00:43:07]

thanks for working on this.

https://chromiumcodereview.appspot.com/10413062/diff/2002/chrome/browser/chro...
File chrome/browser/chromeos/input_method/ibus_controller_impl.cc (right):

https://chromiumcodereview.appspot.com/10413062/diff/2002/chrome/browser/chro...
chrome/browser/chromeos/input_method/ibus_controller_impl.cc:488: void*
attached_data = g_object_get_data(G_OBJECT(ibus_), kPanelObjectKey);
please add a comment which explains when/why g_object_get_data returns null or
an invalid object.

[Seigo Nonaka, 2012-05-23 00:56:59]

https://chromiumcodereview.appspot.com/10413062/diff/2002/chrome/browser/chro...
File chrome/browser/chromeos/input_method/ibus_controller_impl.cc (right):

https://chromiumcodereview.appspot.com/10413062/diff/2002/chrome/browser/chro...
chrome/browser/chromeos/input_method/ibus_controller_impl.cc:488: void*
attached_data = g_object_get_data(G_OBJECT(ibus_), kPanelObjectKey);
I don't know why g_object_get_data fails. (I doubt "g_object_unref" but not not
sure.) I continue to investigate this issue. This fix is just temporally.
On 2012/05/23 00:43:08, Yusuke Sato wrote:
> please add a comment which explains when/why g_object_get_data returns null or
> an invalid object.

[Yusuke Sato, 2012-05-23 01:04:05]

lgtm

On 2012/05/23 00:56:59, Seigo Nonaka wrote:
>
https://chromiumcodereview.appspot.com/10413062/diff/2002/chrome/browser/chro...
> File chrome/browser/chromeos/input_method/ibus_controller_impl.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10413062/diff/2002/chrome/browser/chro...
> chrome/browser/chromeos/input_method/ibus_controller_impl.cc:488: void*
> attached_data = g_object_get_data(G_OBJECT(ibus_), kPanelObjectKey);
> I don't know why g_object_get_data fails. (I doubt "g_object_unref" but not
not
> sure.) I continue to investigate this issue. This fix is just temporally.
> On 2012/05/23 00:43:08, Yusuke Sato wrote:
> > please add a comment which explains when/why g_object_get_data returns null
or
> > an invalid object.

[commit-bot: I haz the power, 2012-05-23 01:19:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/10413062/9001

[commit-bot: I haz the power, 2012-05-23 09:12:59]

Try job failure for 10413062-9001 (retry) (retry) on win_rel for step
"sync_unit_tests".
It's a second try, previously, step "sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...