Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4221)

Unified Diff: chrome/browser/ui/cocoa/page_info_bubble_controller.h

Issue 10413061: Make PageInfoBubble not use BrowserList::GetLastActive and instead obtain a navigator at creation t… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/page_info_bubble_controller.h
===================================================================
--- chrome/browser/ui/cocoa/page_info_bubble_controller.h (revision 138377)
+++ chrome/browser/ui/cocoa/page_info_bubble_controller.h (working copy)
@@ -11,6 +11,10 @@
class PageInfoModel;
class PageInfoModelObserver;
+namespace content {
+class PageNavigator;
+}
+
// This NSWindowController subclass manages the InfoBubbleWindow and view that
// are displayed when the user clicks the security lock icon.
@interface PageInfoBubbleController : BaseBubbleController {
@@ -23,6 +27,9 @@
// The certificate ID for the page, 0 if the page is not over HTTPS.
int certID_;
+
+ // Used for loading pages.
+ content::PageNavigator* navigator_;
}
@property(nonatomic, assign) int certID;
@@ -33,8 +40,10 @@
// cannot be nil.
- (id)initWithPageInfoModel:(PageInfoModel*)model
modelObserver:(PageInfoModelObserver*)bridge
- parentWindow:(NSWindow*)parentWindow;
+ parentWindow:(NSWindow*)parentWindow
+ navigator:(content::PageNavigator*)navigator;
+
// Shows the certificate display window. Note that this will implicitly close
// the bubble because the certificate window will become key. The certificate
// information attaches itself as a sheet to the |parentWindow|.

Powered by Google App Engine
This is Rietveld 408576698