Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Side by Side Diff: Source/WebCore/rendering/RenderBlock.cpp

Issue 10413058: Merge 116357 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/block/positioning/positioned-object-under-split-block-parent-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 616 matching lines...) Expand 10 before | Expand all | Expand 10 after
627 // Someone may have indirectly caused a <q> to split. When this happens , the :after content 627 // Someone may have indirectly caused a <q> to split. When this happens , the :after content
628 // has to move into the inline continuation. Call updateBeforeAfterCont ent to ensure that the inline's :after 628 // has to move into the inline continuation. Call updateBeforeAfterCont ent to ensure that the inline's :after
629 // content gets properly destroyed. 629 // content gets properly destroyed.
630 bool isLastChild = (currChildNextSibling == blockCurr->lastChild()); 630 bool isLastChild = (currChildNextSibling == blockCurr->lastChild());
631 if (document()->usesBeforeAfterRules()) 631 if (document()->usesBeforeAfterRules())
632 blockCurr->children()->updateBeforeAfterContent(blockCurr, AFTER); 632 blockCurr->children()->updateBeforeAfterContent(blockCurr, AFTER);
633 if (isLastChild && currChildNextSibling != blockCurr->lastChild()) 633 if (isLastChild && currChildNextSibling != blockCurr->lastChild())
634 currChildNextSibling = 0; // We destroyed the last child, so now we need to update 634 currChildNextSibling = 0; // We destroyed the last child, so now we need to update
635 // the value of currChildNextSibling. 635 // the value of currChildNextSibling.
636 636
637 // It is possible that positioned objects under blockCurr are going to b e moved to cloneBlock.
638 // Since we are doing layout anyway, it is easier to blow away the entir e list, than
639 // traversing down the subtree looking for positioned children and then remove them
640 // from our positioned objects list.
641 if (currChildNextSibling)
642 blockCurr->removePositionedObjects(0);
643
637 // Now we need to take all of the children starting from the first child 644 // Now we need to take all of the children starting from the first child
638 // *after* currChild and append them all to the clone. 645 // *after* currChild and append them all to the clone.
639 blockCurr->moveChildrenTo(cloneBlock, currChildNextSibling, 0, true); 646 blockCurr->moveChildrenTo(cloneBlock, currChildNextSibling, 0, true);
640 647
641 // Keep walking up the chain. 648 // Keep walking up the chain.
642 currChild = curr; 649 currChild = curr;
643 currChildNextSibling = currChild->nextSibling(); 650 currChildNextSibling = currChild->nextSibling();
644 curr = toRenderBoxModelObject(curr->parent()); 651 curr = toRenderBoxModelObject(curr->parent());
645 } 652 }
646 653
(...skipping 6646 matching lines...) Expand 10 before | Expand all | Expand 10 after
7293 } 7300 }
7294 7301
7295 String ValueToString<RenderBlock::FloatingObject*>::string(const RenderBlock::Fl oatingObject* floatingObject) 7302 String ValueToString<RenderBlock::FloatingObject*>::string(const RenderBlock::Fl oatingObject* floatingObject)
7296 { 7303 {
7297 return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->pi xelSnappedX(), floatingObject->pixelSnappedY(), floatingObject->pixelSnappedMaxX (), floatingObject->pixelSnappedMaxY()); 7304 return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->pi xelSnappedX(), floatingObject->pixelSnappedY(), floatingObject->pixelSnappedMaxX (), floatingObject->pixelSnappedMaxY());
7298 } 7305 }
7299 7306
7300 #endif 7307 #endif
7301 7308
7302 } // namespace WebCore 7309 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/block/positioning/positioned-object-under-split-block-parent-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698