Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: tools/isolate/isolate.py

Issue 10413055: Adjust Commands Paths for Result File on Windows (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/isolate.py
diff --git a/tools/isolate/isolate.py b/tools/isolate/isolate.py
index 252ca0ccb13657f38f71a7625611d94588a651ae..c584b396716943aaf7507cc4e45d97c9ba507620 100755
--- a/tools/isolate/isolate.py
+++ b/tools/isolate/isolate.py
@@ -422,6 +422,11 @@ class CompleteState(object):
command, infiles, read_only = load_isolate(f.read(), error)
command = [eval_variables(i, variables) for i in command]
infiles = [eval_variables(f, variables) for f in infiles]
+
+ # Command paths could contain / or \ on windows. Always normalize
+ # to os.path.sep.
+ command = [i.replace('/', os.path.sep) for i in command]
M-A Ruel 2012/05/23 00:34:09 It'll blow up. What is the problem exactly? (And
+
# root_dir is automatically determined by the deepest root accessed with the
# form '../../foo/bar'.
root_dir = determine_root_dir(relative_base_dir, infiles)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698