Issue 10413055: Adjust Commands Paths for Result File on Windows

Issue 10413055: Adjust Commands Paths for Result File on Windows (Closed)

Created:
8 years, 7 months ago by csharp

Modified:
8 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Adjust Paths before Execution Ensure that the file paths passed to subprocess contain the appropriate separators for their OS. NOTRY=true R=maruel@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138594

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	testing/test_env.py	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	tools/isolate/run_test_from_archive.py	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

https://chromiumcodereview.appspot.com/10413055/diff/1/tools/isolate/isolate.py File tools/isolate/isolate.py (right): https://chromiumcodereview.appspot.com/10413055/diff/1/tools/isolate/isolate.py#newcode428 tools/isolate/isolate.py:428: command = [i.replace('/', os.path.sep) for i in command] It'll ...

8 years, 7 months ago (2012-05-23 00:34:09 UTC) #2

csharp

run_test_from_archive is where the problem is appearing, so I fixed it up as well. http://chromegw/i/chromium.swarm/builders/Windows%20Swarm%20Tests%20%281%29/builds/13549/steps/base_unittests_swarm/logs/stdio

8 years, 7 months ago (2012-05-23 14:25:17 UTC) #3

M-A Ruel

lgtm https://chromiumcodereview.appspot.com/10413055/diff/7001/testing/test_env.py File testing/test_env.py (right): https://chromiumcodereview.appspot.com/10413055/diff/7001/testing/test_env.py#newcode26 testing/test_env.py:26: # Ensure paths are correctly separatored on windows. ...

8 years, 7 months ago (2012-05-23 14:26:15 UTC) #4

csharp

https://chromiumcodereview.appspot.com/10413055/diff/7001/testing/test_env.py File testing/test_env.py (right): https://chromiumcodereview.appspot.com/10413055/diff/7001/testing/test_env.py#newcode26 testing/test_env.py:26: # Ensure paths are correctly separatored on windows. On ...

8 years, 7 months ago (2012-05-23 14:29:46 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10413055/9003

8 years, 7 months ago (2012-05-23 14:29:57 UTC) #6

commit-bot: I haz the power

Try job failure for 10413055-9003 (retry) on win_rel for step "unit_tests". It's a second try, ...

8 years, 7 months ago (2012-05-23 19:56:57 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10413055/9003

8 years, 7 months ago (2012-05-23 19:59:06 UTC) #8

Change committed as 138594

Expand Messages | Collapse Messages