Issue 10413054: Make ExtensionTtsPlatformImplWin a leaky singleton to avoid a crash in the destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10413054: Make ExtensionTtsPlatformImplWin a leaky singleton to avoid a crash in the destructor. (Closed)

Created:
8 years, 7 months ago by dmazzoni

Modified:
8 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Aaron Boodman, Satish, mihaip-chromium-reviews_chromium.org, David Tseng, dharani1

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Make ExtensionTtsPlatformImplWin a leaky singleton to avoid a crash in the destructor. BUG=122026 TEST=Does not crash on shutdown on XP. Speech still stops if you load TTS Demo and exit in the middle of a long sentence. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138393

Patch Set 1 #

Patch Set 2 : Clarified comment #

Total comments: 2

Patch Set 3 : Add crbug link to comment #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/speech/extension_api/tts_extension_api_platform.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/speech/extension_api/tts_extension_api_win.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

lgtm http://codereview.chromium.org/10413054/diff/2001/chrome/browser/speech/extension_api/tts_extension_api_platform.h File chrome/browser/speech/extension_api/tts_extension_api_platform.h (right): http://codereview.chromium.org/10413054/diff/2001/chrome/browser/speech/extension_api/tts_extension_api_platform.h#newcode56 chrome/browser/speech/extension_api/tts_extension_api_platform.h:56: // On some platforms this may be a ...

8 years, 7 months ago (2012-05-22 22:49:56 UTC) #2

dmazzoni

8 years, 7 months ago (2012-05-22 22:56:31 UTC) #3

http://codereview.chromium.org/10413054/diff/2001/chrome/browser/speech/exten...
File chrome/browser/speech/extension_api/tts_extension_api_platform.h (right):

http://codereview.chromium.org/10413054/diff/2001/chrome/browser/speech/exten...
chrome/browser/speech/extension_api/tts_extension_api_platform.h:56: // On some
platforms this may be a leaky singleton - do not rely on the
On 2012/05/22 22:49:56, Aaron Boodman wrote:
> Insert a blank line above this. Also, can you add a http://crbug.com link to
the issue
> where this is being discussed?

Done, thanks.

Expand Messages | Collapse Messages