Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 10413050: Make content_shell talk to run_webkit_tests.py (Closed)

Created:
8 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Make content_shell talk to run_webkit_tests.py This adds the command line option --check-layout-test-systems-deps (which just checks that content_shell can initialize itself), and prints the necessary block markers around the text output required by run_webkit_test.py BUG=111316 TEST=none NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138303

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M content/shell/shell_browser_main.cc View 4 chunks +13 lines, -2 lines 0 comments Download
M content/shell/shell_render_view_host_observer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/shell_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
please review
8 years, 7 months ago (2012-05-22 13:40:19 UTC) #1
jam
lgtm
8 years, 7 months ago (2012-05-22 15:41:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10413050/1
8 years, 7 months ago (2012-05-22 16:47:43 UTC) #3
commit-bot: I haz the power
Try job failure for 10413050-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-22 18:04:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10413050/1
8 years, 7 months ago (2012-05-22 18:13:04 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 18:55:23 UTC) #6
Change committed as 138303

Powered by Google App Engine
This is Rietveld 408576698