Use existing model for initial layout, if we can.

Use existing model for initial layout, if we can.


BUG=128880
TEST=Try to repro the bug (with an empty profile), see it doesn't happen.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138283

[Robert Sesek, 2012-05-22 00:19:53]

https://chromiumcodereview.appspot.com/10413044/diff/1/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/web_intent_picker_cocoa.h (right):

https://chromiumcodereview.appspot.com/10413044/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/web_intent_picker_cocoa.h:36: WebIntentPickerModel*
get_model() { return model_; }
naming: Getters are just the name of the ivar, sans trailing _, so model().

https://chromiumcodereview.appspot.com/10413044/diff/1/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/web_intent_sheet_controller.mm (right):

https://chromiumcodereview.appspot.com/10413044/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:465: model_ = NULL;
Cocoa will initialize this for you to 0, so you don't need the else branch.

[groby-ooo-7-16, 2012-05-22 00:32:08]

https://chromiumcodereview.appspot.com/10413044/diff/1/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/web_intent_picker_cocoa.h (right):

https://chromiumcodereview.appspot.com/10413044/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/web_intent_picker_cocoa.h:36: WebIntentPickerModel*
get_model() { return model_; }
On 2012/05/22 00:19:54, rsesek wrote:
> naming: Getters are just the name of the ivar, sans trailing _, so model().

Done.

https://chromiumcodereview.appspot.com/10413044/diff/1/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/web_intent_sheet_controller.mm (right):

https://chromiumcodereview.appspot.com/10413044/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:465: model_ = NULL;
On 2012/05/22 00:19:54, rsesek wrote:
> Cocoa will initialize this for you to 0, so you don't need the else branch.

Done.

[Robert Sesek, 2012-05-22 00:46:56]

lgtm

[commit-bot: I haz the power, 2012-05-22 01:04:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/10413044/7001

[commit-bot: I haz the power, 2012-05-22 05:47:47]

Try job failure for 10413044-7001 (retry) (retry) on win_rel for steps
"base_unittests, sync_unit_tests".
It's a second try, previously, steps "base_unittests, sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...