editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java - Issue 10413041: Propagate variable type in TypeAnalyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

Issue 10413041: Propagate variable type in TypeAnalyzer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixes for review comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java ('k') | editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/TestAll.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

index 80728081c3c41e4dea17158e056f369a5e525d53..d83e1adf950dd4776ee14123fe3513578968e70a 100644

--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

@@ -70,8 +70,6 @@ import com.google.dart.compiler.resolver.LibraryElement;

import com.google.dart.compiler.resolver.MethodElement;

import com.google.dart.compiler.resolver.MethodNodeElement;

import com.google.dart.compiler.resolver.NodeElement;

-import com.google.dart.compiler.resolver.ResolutionContext;

-import com.google.dart.compiler.resolver.Resolver;

import com.google.dart.compiler.resolver.Scope;

import com.google.dart.compiler.resolver.VariableElement;

import com.google.dart.compiler.type.FunctionType;

@@ -1485,24 +1483,6 @@ public class CompletionEngine {

classElement = resolvedClass.getElement();

}

- context.reset();

- Resolver resolver = new Resolver(context, unitScope, typeProvider);

- ResolutionContext resolutionContext = new ResolutionContext(unitScope, context, typeProvider);

- if (classElement != null) {

- resolutionContext = resolutionContext.extend(classElement);

- }

- NodeElement member = resolvedMember == null ? classElement : resolvedMember.getElement();

- try {

- resolver.resolveMember(classElement, member, resolutionContext);

- } catch (AssertionError ex) {

- // Expected if completing an extends or implements clause of type declaration

- } catch (NullPointerException ex) {

- // Expected if completing an extends or implements clause of type declaration

- } catch (Throwable ex) {

- DartCore.logError(ex);

- ex.printStackTrace();

- }

requestor.beginReporting();

requestor.acceptContext(new InternalCompletionContext());

resolvedNode.accept(new OuterCompletionProposer(resolvedNode));