Issue 10413040: Use GetMin() instead of start(). Sometimes start > end.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10413040: Use GetMin() instead of start(). Sometimes start > end. (Closed)

Created:
8 years, 7 months ago by Jun Mukai

Modified:
8 years, 7 months ago

Reviewers:
Peter Kasting, sky

CC:
chromium-reviews, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use GetMin() instead of start(). Sometimes start > end. BUG=129047 TEST=manually checked on Goobuntu and Lumpy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138177

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/10413040/1

8 years, 7 months ago (2012-05-21 22:33:48 UTC) #3

commit-bot: I haz the power

8 years, 7 months ago (2012-05-21 23:32:52 UTC) #4

Try job failure for 10413040-1 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Expand Messages | Collapse Messages