Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc

Issue 10413039: Valgrind: Fix a leak. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc
diff --git a/chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc b/chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc
index cce0152a22efb5c5def8d6fb03e9cea1fc6d1106..11525476ac2a4709f34e4e14cbde5111a35bd3af 100644
--- a/chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc
+++ b/chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc
@@ -105,6 +105,14 @@ class WebAuthFlowTest : public ChromeRenderViewHostTestHarness {
ChromeRenderViewHostTestHarness::SetUp();
}
+ virtual void TearDown() {
+ // |flow_| must be reset before ChromeRenderViewHostTestHarness::TearDown(),
+ // because |flow_| deletes the WebContents it owns via
+ // MessageLoop::DeleteSoon().
+ flow_.reset();
+ ChromeRenderViewHostTestHarness::TearDown();
+ }
+
void CreateAuthFlow(const std::string& extension_id, const GURL& url) {
flow_.reset(new MockWebAuthFlow(&delegate_, profile(), extension_id, url));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698