Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 10413034: fix warning compiling allocator/tcmalloc on win32 (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 7 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

fix warning compiling allocator/tcmalloc on win32 ..\..\third_party\tcmalloc\chromium\src\windows\port.cc(38) : warning C4005: 'NOMINMAX' : macro redefinition command-line arguments : see previous definition of 'NOMINMAX' R=jar@chromium.org BUG=126483 NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M base/allocator/allocator.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
8 years, 7 months ago (2012-05-21 20:26:09 UTC) #1
jar (doing other things)
lgtm
8 years, 7 months ago (2012-05-21 22:27:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10413034/1
8 years, 7 months ago (2012-05-21 22:31:14 UTC) #3
commit-bot: I haz the power
Try job failure for 10413034-1 (retry) (retry) on win_rel for steps "base_unittests, sync_unit_tests" (clobber build). ...
8 years, 7 months ago (2012-05-22 03:51:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10413034/1
8 years, 7 months ago (2012-05-22 16:38:32 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 16:40:06 UTC) #6
Change committed as 138274

Powered by Google App Engine
This is Rietveld 408576698