Issue 10413022: Move dir_reader to base/files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10413022: Move dir_reader to base/files (Closed)

Created:
8 years, 7 months ago by brettw

Modified:
8 years, 5 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Move dir_reader to base/files TEST=it compiles BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144989

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -282 lines)			Patch
M	base/base.gyp	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/base.gypi	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
D	base/dir_reader_fallback.h	View		1 chunk	+0 lines, -31 lines	0 comments	Download
D	base/dir_reader_linux.h	View		1 chunk	+0 lines, -99 lines	0 comments	Download
D	base/dir_reader_posix.h	View		1 chunk	+0 lines, -37 lines	0 comments	Download
D	base/dir_reader_posix_unittest.cc	View		1 chunk	+0 lines, -92 lines	0 comments	Download
A +	base/files/dir_reader_fallback.h	View	2 3	2 chunks	+10 lines, -5 lines	0 comments	Download
A +	base/files/dir_reader_linux.h	View	2 3	2 chunks	+4 lines, -4 lines	0 comments	Download
A +	base/files/dir_reader_posix.h	View	1 2 3	3 chunks	+6 lines, -6 lines	0 comments	Download
A +	base/files/dir_reader_posix_unittest.cc	View	2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/external_pref_extension_loader.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

brettw

Since you sent me a cleanup patch, here's one for you. I'm just trying to ...

8 years, 5 months ago (2012-06-28 20:55:17 UTC) #1

LGTM :)