Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: sync/notifier/sync_notifier_factory.cc

Issue 10413014: [Sync] Turn notifier::PushClient into an interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync to head Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/notifier/p2p_notifier_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/notifier/sync_notifier_factory.h" 5 #include "sync/notifier/sync_notifier_factory.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "jingle/notifier/listener/push_client.h"
10 #include "sync/notifier/non_blocking_invalidation_notifier.h" 11 #include "sync/notifier/non_blocking_invalidation_notifier.h"
11 #include "sync/notifier/p2p_notifier.h" 12 #include "sync/notifier/p2p_notifier.h"
12 #include "sync/notifier/sync_notifier.h" 13 #include "sync/notifier/sync_notifier.h"
13 14
14 namespace sync_notifier { 15 namespace sync_notifier {
15 namespace { 16 namespace {
16 17
17 SyncNotifier* CreateDefaultSyncNotifier( 18 SyncNotifier* CreateDefaultSyncNotifier(
18 const notifier::NotifierOptions& notifier_options, 19 const notifier::NotifierOptions& notifier_options,
19 const InvalidationVersionMap& initial_max_invalidation_versions, 20 const InvalidationVersionMap& initial_max_invalidation_versions,
20 const browser_sync::WeakHandle<InvalidationStateTracker>& 21 const browser_sync::WeakHandle<InvalidationStateTracker>&
21 invalidation_state_tracker, 22 invalidation_state_tracker,
22 const std::string& client_info) { 23 const std::string& client_info) {
23 if (notifier_options.notification_method == notifier::NOTIFICATION_P2P) { 24 if (notifier_options.notification_method == notifier::NOTIFICATION_P2P) {
24 // TODO(rlarocque): Ideally, the notification target would be 25 // TODO(rlarocque): Ideally, the notification target would be
25 // NOTIFY_OTHERS. There's no good reason to notify ourselves of our own 26 // NOTIFY_OTHERS. There's no good reason to notify ourselves of our own
26 // commits. We self-notify for now only because the integration tests rely 27 // commits. We self-notify for now only because the integration tests rely
27 // on this behaviour. See crbug.com/97780. 28 // on this behaviour. See crbug.com/97780.
28 return new P2PNotifier(notifier_options, NOTIFY_ALL); 29 return new P2PNotifier(
30 notifier::PushClient::CreateDefault(notifier_options),
31 NOTIFY_ALL);
29 } 32 }
30 33
31 return new NonBlockingInvalidationNotifier( 34 return new NonBlockingInvalidationNotifier(
32 notifier_options, initial_max_invalidation_versions, 35 notifier_options, initial_max_invalidation_versions,
33 invalidation_state_tracker, client_info); 36 invalidation_state_tracker, client_info);
34 } 37 }
35 38
36 } // namespace 39 } // namespace
37 40
38 // TODO(akalin): Remove the dependency on jingle if OS_ANDROID is defined. 41 // TODO(akalin): Remove the dependency on jingle if OS_ANDROID is defined.
(...skipping 19 matching lines...) Expand all
58 // Android uses ChromeSyncNotificationBridge exclusively. 61 // Android uses ChromeSyncNotificationBridge exclusively.
59 return NULL; 62 return NULL;
60 #else 63 #else
61 return CreateDefaultSyncNotifier(notifier_options_, 64 return CreateDefaultSyncNotifier(notifier_options_,
62 initial_max_invalidation_versions_, 65 initial_max_invalidation_versions_,
63 invalidation_state_tracker_, 66 invalidation_state_tracker_,
64 client_info_); 67 client_info_);
65 #endif 68 #endif
66 } 69 }
67 } // namespace sync_notifier 70 } // namespace sync_notifier
OLDNEW
« no previous file with comments | « sync/notifier/p2p_notifier_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698