Issue 10413012: Cleanup: Remove unneeded scoped_ptr.h includes from chrome/browser/ui.

Issue 10413012: Cleanup: Remove unneeded scoped_ptr.h includes from chrome/browser/ui. (Closed)

Created:
8 years, 7 months ago by Lei Zhang

Modified:
8 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, asanka, jennb, nkostylev+watch_chromium.org, Dmitry Titov, jianli, Randy Smith (Not in Mondays), dcheng, James Su, Andrei

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Cleanup: Remove unneeded scoped_ptr.h includes from chrome/browser/ui. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138228

Patch Set 2 : remove panel.h #

Patch Set 3 : rebase #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -21 lines)			Patch
M	chrome/browser/ui/fullscreen_exit_bubble.h	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/global_menu_bar.h	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/tabs/dragged_view_gtk.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/panels/base_panel_browser_test.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_frame_view.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/prefs/prefs_tab_helper.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/glass_browser_frame_view.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/sad_tab_view.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/eula_screen_handler.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/network_screen_handler.h	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/downloads_dom_handler.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/omnibox/omnibox_ui.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/options_ui2_browsertest.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/suggestions_internals/suggestions_internals_ui.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jennb

drive-by https://chromiumcodereview.appspot.com/10413012/diff/1/chrome/browser/ui/panels/panel.h File chrome/browser/ui/panels/panel.h (left): https://chromiumcodereview.appspot.com/10413012/diff/1/chrome/browser/ui/panels/panel.h#oldcode12 chrome/browser/ui/panels/panel.h:12: #include "base/memory/scoped_ptr.h" Could you leave this one unchanged? ...

8 years, 7 months ago (2012-05-18 23:17:01 UTC) #2

Lei Zhang

https://chromiumcodereview.appspot.com/10413012/diff/1/chrome/browser/ui/panels/panel.h File chrome/browser/ui/panels/panel.h (left): https://chromiumcodereview.appspot.com/10413012/diff/1/chrome/browser/ui/panels/panel.h#oldcode12 chrome/browser/ui/panels/panel.h:12: #include "base/memory/scoped_ptr.h" On 2012/05/18 23:17:01, jennb wrote: > Could ...

8 years, 7 months ago (2012-05-18 23:22:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10413012/22

8 years, 7 months ago (2012-05-21 18:56:52 UTC) #5

commit-bot: I haz the power

8 years, 7 months ago (2012-05-22 01:15:04 UTC) #6

Try job failure for 10413012-22 (retry) (retry) (retry) on win_rel for steps
"base_unittests, sync_unit_tests".
It's a second try, previously, steps "base_unittests, sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages