redo r137692 and r137791 which were speculatively reverted

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * FileManager constructor.
  *
  * FileManager objects encapsulate the functionality of the file selector
  * dialogs, as well as the full screen file manager application (though the
  * latter is not yet implemented).
@@ skipping 103 matching lines @@
   var IMAGE_HOVER_PREVIEW_SIZE = 200;
 
   /**
    * The minimum about of time to display the butter bar for, in ms.
    * Justification is 1000ms for minimum display time plus 300ms for transition
    * duration.
    */
   var MINIMUM_BUTTER_DISPLAY_TIME_MS = 1300;
 
   /**
-   * Translated strings.
-   */
-  var localStrings;
-
-  /**
    * Item for the Grid View.
    * @constructor
    */
   function GridItem(fileManager, entry) {
     var li = fileManager.document_.createElement('li');
     GridItem.decorate(li, fileManager, entry);
     return li;
   }
 
   GridItem.prototype = {
@@ skipping 10 matching lines @@
 
   GridItem.decorate = function(li, fileManager, entry) {
     li.__proto__ = GridItem.prototype;
     fileManager.decorateThumbnail_(li, entry);
   };
 
   /**
    * Return a translated string.
    *
    * Wrapper function to make dealing with translated strings more concise.
-   * Equivilant to localStrings.getString(id).
+   * Equivalent to loadTimeData.getString(id).
    *
    * @param {string} id The id of the string to return.
    * @return {string} The translated string.
    */
   function str(id) {
-    return localStrings.getString(id) || ('UNLOCALIZED STRING ' + id);
+    return loadTimeData.getString(id);
   }
 
   /**
    * Return a translated string with arguments replaced.
    *
    * Wrapper function to make dealing with translated strings more concise.
-   * Equivilant to localStrings.getStringF(id, ...).
+   * Equivilant to loadTimeData.getStringF(id, ...).
    *
    * @param {string} id The id of the string to return.
    * @param {...string} The values to replace into the string.
    * @return {string} The translated string with replaced values.
    */
   function strf(id, var_args) {
-    return localStrings.getStringF.apply(localStrings, arguments);
+    return loadTimeData.getStringF.apply(loadTimeData, arguments);
   }
 
   /**
    * @param {number} code File error code (from FileError object).
    * @return {string} Translated file error string.
    */
   function getFileErrorString(code) {
     for (var key in FileError) {
       var match = /(.*)_ERR$/.exec(key);
       if (match && FileError[key] == code) {
         // This would convert 1 to 'NOT_FOUND'.
         code = match[1];
         break;
       }
     }
-    return localStrings.getString('FILE_ERROR_' + code) ||
-        localStrings.getStringF('FILE_ERROR_GENERIC', code);
+    return loadTimeData.getString('FILE_ERROR_' + code) ||
+        loadTimeData.getStringF('FILE_ERROR_GENERIC', code);
   }
 
   /**
    * Checks if |parent_path| is parent file path of |child_path|.
    *
    * @param {string} parent_path The parent path.
    * @param {string} child_path The child path.
    */
   function isParentPath(parent_path, child_path) {
     if (!parent_path || parent_path.length == 0 ||
@@ skipping 60 matching lines @@
   FileManager.ListType = {
     DETAIL: 'detail',
     THUMBNAIL: 'thumb'
   };
 
   /**
    * Load translated strings.
    */
   FileManager.initStrings = function(callback) {
     chrome.fileBrowserPrivate.getStrings(function(strings) {
-      localStrings = new LocalStrings(strings);
+      loadTimeData.data = strings;
       if (callback)
         callback();
     });
   };
 
   // Instance methods.
 
   /**
    * Request local file system, resolve roots and init_ after that.
    * @private
@@ skipping 316 matching lines @@
     this.hostedButton.addEventListener('click', this.onGDataPrefClick_.bind(
         this, 'hostedFilesDisabled', true /* inverted */));
 
     cr.ui.ComboButton.decorate(this.taskItems_);
     this.taskItems_.addEventListener('select',
         this.onTaskItemClicked_.bind(this));
 
     this.dialogDom_.ownerDocument.defaultView.addEventListener(
         'resize', this.onResize_.bind(this));
 
-    if (str('ASH') == '1')
+    if (loadTimeData.getBoolean('ASH'))
       this.dialogDom_.setAttribute('ash', 'true');
 
     this.filePopup_ = null;
 
     this.dialogDom_.querySelector('#search-box').addEventListener(
         'input', this.onSearchBoxUpdate_.bind(this));
 
     // Populate the static localized strings.
-    i18nTemplate.process(this.document_, localStrings.templateData);
+    i18nTemplate.process(this.document_, loadTimeData);
   };
 
   /**
    * Constructs table and grid (heavy operation).
    **/
   FileManager.prototype.initFileList_ = function() {
     // Always sharing the data model between the detail/thumb views confuses
     // them.  Instead we maintain this bogus data model, and hook it up to the
     // view that is not in use.
     this.emptyDataModel_ = new cr.ui.ArrayDataModel([]);
@@ skipping 1829 matching lines @@
                 chrome.extension.getURL('images/filetype_generic.png');
           } else {
             // Use specific icon.
             var icon = FileType.getIcon(selection.urls[0]);
             task.iconUrl =
                 chrome.extension.getURL('images/filetype_' + icon + '.png');
           }
           task.title = str('ACTION_OPEN');
         } else if (task_parts[1] == 'view-pdf') {
           // Do not render this task if disabled.
-          if (str('PDF_VIEW_ENABLED') == 'false') continue;
+          if (!loadTimeData.getBoolean('PDF_VIEW_ENABLED'))
+            continue;
+
           task.iconUrl =
               chrome.extension.getURL('images/filetype_pdf.png');
           task.title = str('ACTION_VIEW');
         } else if (task_parts[1] == 'view-in-browser') {
           task.iconUrl =
               chrome.extension.getURL('images/filetype_generic.png');
           task.title = str('ACTION_VIEW');
         } else if (task_parts[1] == 'install-crx') {
           task.iconUrl =
               chrome.extension.getURL('images/filetype_generic.png');
@@ skipping 153 matching lines @@
         }
         callback(urls);
       }.bind(this));
     } else {
       callback(urls);
     }
   };
 
   FileManager.prototype.getGDataPreferences_ = function() {
     return this.gdataPreferences_ ||
-      { driveEnabled: str('ENABLE_GDATA') == '1' };
+      { driveEnabled: loadTimeData.getBoolean('ENABLE_GDATA') };
   };
 
   FileManager.prototype.getNetworkConnectionState_ = function() {
     return this.networkConnectionState_ || {};
   };
 
   FileManager.prototype.onNetworkConnectionChanged_ = function(state) {
     console.log(state.online ? 'online' : 'offline', state.type);
     this.networkConnectionState_ = state;
     this.directoryModel_.setOffline(!state.online);
@@ skipping 2000 matching lines @@
 
     function closeBanner() {
       self.cleanupGDataWelcome_();
       // Stop showing the welcome banner.
       localStorage[WELCOME_HEADER_COUNTER_KEY] = WELCOME_HEADER_COUNTER_LIMIT;
     }
 
     return maybeShowBanner;
   };
 })();