Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 10413011: redo r137692 and r137791 which were speculatively reverted (Closed)

Created:
8 years, 7 months ago by Evan Stade
Modified:
8 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

redo r137692 and r137791 which were speculatively reverted but turned out not to be causing breakage (although the former had caused some failures, the latter fixed it). convert chromeos file manager to loadTimeData BUG=122753 TEST=manual,unit change type of fileBrowserApi.getStrings it can get things that aren't necessarily strings. It's a dictionary of all types. BUG=none TEST=SelectFileDialogExtensionBrowserTest.OpenSingletonTabAndCancel and others on chromiumOS dbg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -166 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 8 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/resources/file_manager/js/main_scripts.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/file_browser_private.json View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/api_index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/processes/process_monitor.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/experimental.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/experimental.downloads.html View 2 chunks +2 lines, -18 lines 0 comments Download
M chrome/common/extensions/docs/experimental.processes.html View 34 chunks +33 lines, -103 lines 0 comments Download
M chrome/common/extensions/docs/samples.html View 12 chunks +35 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/samples.json View 12 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
TBR
8 years, 7 months ago (2012-05-18 19:16:07 UTC) #1
Evan Stade
8 years, 7 months ago (2012-05-18 19:16:07 UTC) #2
TBR

Powered by Google App Engine
This is Rietveld 408576698