Issue 10413004: Try to fix failing tests after 1386.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10413004: Try to fix failing tests after 1386. (Closed)

Created:
8 years, 7 months ago by Nico

Modified:
8 years, 7 months ago

Reviewers:
scottmg

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Try to fix failing tests after 1386. TBR=scottmg Committed: https://code.google.com/p/gyp/source/detail?r=1387

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	test/defines/defines.c	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	test/defines/gyptest-defines-env-regyp.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

The file I changed is used by several tests, not all of which define HASH_VALUE.

8 years, 7 months ago (2012-05-18 13:46:56 UTC) #1

scottmg

8 years, 7 months ago (2012-05-18 22:56:25 UTC) #2

On 2012/05/18 13:46:56, Nico wrote:
> The file I changed is used by several tests, not all of which define
HASH_VALUE.

looks like this is failing on 2010 only? 
http://build.chromium.org/p/tryserver.nacl/builders/gyp-win64/builds/335/step...

managing to overcome your octalizing and trying *extra hard* to convert # to =.

separate test and !msvs seems reasonable to me.

Expand Messages | Collapse Messages