Change to use webkit intent delivery.

Change to use webkit intent delivery.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141229

[darin (slow to review), 2012-06-05 18:22:18]

http://codereview.chromium.org/10412058/diff/2001/content/renderer/web_intent...
File content/renderer/web_intents_host.cc (right):

http://codereview.chromium.org/10412058/diff/2001/content/renderer/web_intent...
content/renderer/web_intents_host.cc:42: virtual void postResult(const
WebSerializedScriptValue& data) const OVERRIDE {
Note: We often do not use OVERRIDE when implementing WebKit defined interfaces
in Chromium because that makes it harder to change those interfaces.  There's a
tradeoff: using OVERRIDE helps you avoid mistakes, but it also makes it harder
to change interfaces.  Up to you.

http://codereview.chromium.org/10412058/diff/2001/content/renderer/web_intent...
content/renderer/web_intents_host.cc:130: WebKit::WebVector<WebKit::WebString>
extras_keys(
nit: no WebKit:: in front of WebString

http://codereview.chromium.org/10412058/diff/2001/content/renderer/web_intent...
content/renderer/web_intents_host.cc:149: web_intent.reset(new
WebIntent(intent_->action,
does some of this code need to be updated?

[Greg Billock, 2012-06-05 19:55:45]

http://codereview.chromium.org/10412058/diff/2001/content/renderer/web_intent...
File content/renderer/web_intents_host.cc (right):

http://codereview.chromium.org/10412058/diff/2001/content/renderer/web_intent...
content/renderer/web_intents_host.cc:42: virtual void postResult(const
WebSerializedScriptValue& data) const OVERRIDE {
Took 'em out.

On 2012/06/05 18:22:18, darin wrote:
> Note: We often do not use OVERRIDE when implementing WebKit defined interfaces
> in Chromium because that makes it harder to change those interfaces.  There's
a
> tradeoff: using OVERRIDE helps you avoid mistakes, but it also makes it harder
> to change interfaces.  Up to you.

http://codereview.chromium.org/10412058/diff/2001/content/renderer/web_intent...
content/renderer/web_intents_host.cc:130: WebKit::WebVector<WebKit::WebString>
extras_keys(
On 2012/06/05 18:22:18, darin wrote:
> nit: no WebKit:: in front of WebString

Done.

http://codereview.chromium.org/10412058/diff/2001/content/renderer/web_intent...
content/renderer/web_intents_host.cc:149: web_intent.reset(new
WebIntent(intent_->action,
On 2012/06/05 18:22:18, darin wrote:
> does some of this code need to be updated?

Yes. Didn't push the new version. Now done.

[darin (slow to review), 2012-06-05 20:01:57]

LGTM

[commit-bot: I haz the power, 2012-06-08 16:09:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/10412058/6002

[commit-bot: I haz the power, 2012-06-08 17:34:20]

Change committed as 141229